Add support for custom .env file path #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Feb 16, 2022
jjlin
suggested changes
Feb 16, 2022
There was a problem hiding this comment.
There should also be some docs towards the top of https://github.com/dani-garcia/vaultwarden/blob/main/.env.template so people know this env var is available
|
I should mention that another solution to this is to cd to the directory containing the This works for my use case, but I'll leave this PR here in case it's seen as a benefit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm working on packaging this for Void, and in writing the runit service, I came across an annoyance: since the
.envfile can't be in the current working directory, it won't find it and thus has to read from the environment variables directly. This can be done with something like:But that is less than ideal IMO. This patch is a simple way to pass a single custom location where the env/config can be found.